Skip to content

[FLINK-34467] bump flink version to 1.20.0#137

Merged
leonardBang merged 1 commit intoapache:mainfrom
HuangZhenQiu:FLINK-34467-bump-flink-version
Oct 21, 2024
Merged

[FLINK-34467] bump flink version to 1.20.0#137
leonardBang merged 1 commit intoapache:mainfrom
HuangZhenQiu:FLINK-34467-bump-flink-version

Conversation

@HuangZhenQiu
Copy link
Contributor

@HuangZhenQiu HuangZhenQiu commented Aug 11, 2024

Bump flink version to 1.20.0 for preparing lineage integration.

@boring-cyborg
Copy link

boring-cyborg bot commented Aug 11, 2024

Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html)

@leonardBang leonardBang self-requested a review August 13, 2024 02:17
@HuangZhenQiu HuangZhenQiu force-pushed the FLINK-34467-bump-flink-version branch from 783c489 to c509855 Compare September 20, 2024 04:10
@leonardBang
Copy link
Contributor

leonardBang commented Sep 24, 2024

@lvyanquan Would you like to review this PR when you have time?

@HuangZhenQiu HuangZhenQiu force-pushed the FLINK-34467-bump-flink-version branch from c509855 to 844cb0a Compare September 25, 2024 00:36
@HuangZhenQiu HuangZhenQiu force-pushed the FLINK-34467-bump-flink-version branch 7 times, most recently from 0209712 to c57dc43 Compare October 14, 2024 13:17
@HuangZhenQiu
Copy link
Contributor Author

HuangZhenQiu commented Oct 14, 2024

The build is successful in my personal CI

https://github.com/HuangZhenQiu/flink-connector-jdbc/actions/runs/11328373650

@HuangZhenQiu
Copy link
Contributor Author

HuangZhenQiu commented Oct 15, 2024

@flinkbot run

@lvyanquan
Copy link
Contributor

lvyanquan commented Oct 15, 2024

I've read your discussions in Kafka connector community, as we already release a 3.2 version to support flink 1.19, and refer to AHeise's comment, we can add bugfixs to 3.2.1 if necessary.
So this version bumping is acceptable to me, and we need a follow-up PR to set the build version to 3.3-SNAPSHOT to avoid occupying the minor version 3.2.1.

lvyanquan
lvyanquan reviewed Oct 15, 2024
View reviewed changes
@HuangZhenQiu HuangZhenQiu force-pushed the FLINK-34467-bump-flink-version branch 2 times, most recently from 092e8b6 to a25021b Compare October 15, 2024 17:06
lvyanquan
lvyanquan reviewed Oct 16, 2024
View reviewed changes
@HuangZhenQiu HuangZhenQiu force-pushed the FLINK-34467-bump-flink-version branch from a25021b to 28f4426 Compare October 16, 2024 06:11
lvyanquan
lvyanquan approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@lvyanquan lvyanquan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

leonardBang
leonardBang approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@leonardBang leonardBang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from my side, thanks @HuangZhenQiu @lvyanquan for the nice work

@leonardBang leonardBang merged commit 72f315f into apache:main Oct 21, 2024
@boring-cyborg
Copy link

boring-cyborg bot commented Oct 21, 2024

Awesome work, congrats on your first merged pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leonardBang leonardBang leonardBang approved these changes

@lvyanquan lvyanquan lvyanquan approved these changes

Assignees

No one assigned

Labels

component=BuildSystem component=JDBC/Core

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@HuangZhenQiu @leonardBang @lvyanquan